Merged
Conversation
In order to make it easy to test against python2 and python3 use tox. Also update .gitignore to cover related files
* use print from future * new notation for longs
* Stop using decode('utf8') in tests
* str.lower() instead of string.lower(str)
Add python3 support using six.
So https://github.com/brettcannon/caniusepython3 will detect urlnorm as supporting python3.
new version supports python3
jparise
approved these changes
Feb 9, 2018
| from __future__ import absolute_import | ||
| from six import unichr | ||
| import six | ||
| from six.moves import range |
Collaborator
There was a problem hiding this comment.
Could you consolidate these six imports?
Author
There was a problem hiding this comment.
not sure why its done this way, but this is what python-modernize automatically did
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add python 3 support, tested via tox on both python2.7 and 3.6
Backport of jehiah#23